Bug 27488 - re-order some arguments to put the GError ** at the end, to be nice to Vala
Summary: re-order some arguments to put the GError ** at the end, to be nice to Vala
Status: RESOLVED FIXED
Alias: None
Product: Wocky
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords: patch
Depends on: 27244
Blocks:
  Show dependency tree / graph
 
Reported: 2010-04-06 07:13 UTC by Simon McVittie
Modified: 2010-06-15 07:45 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Simon McVittie 2010-04-06 07:13:46 UTC 
Cloned from Bug #27244:

> One more thing, slightly off-topic, would you be okay with changing
> wocky_connector_{connect,register}_finish so the GError is put as the last
> argument instead of middle? That would make Vala async binding "just work". :-)
Comment 1 Simon McVittie 2010-04-20 08:04:32 UTC 
Sorry, the branch URL here was an artefact of the bug having been cloned.
Comment 2 Simon McVittie 2010-06-15 06:57:58 UTC 
See URL for a patch to do this in the simple cases. I didn't alter wocky_stanza_extract_errors or wocky_xmpp_error_extract, because they don't fit the usual pattern anyway.
Comment 3 Simon McVittie 2010-06-15 07:45:52 UTC 
Fixed in git, will be in the Gabble 0.9.14 snapshot.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.