| Summary: | tp_g_signal_connect_object: Support G_CONNECT_AFTER flag. | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Mike Ruprecht <cmaiku> |
| Component: | tp-glib | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/g-connect-after | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
|
Description
Mike Ruprecht
2010-04-17 01:48:47 UTC
Looks good, but if we only actually support certain GConnectFlags, the doc-comment should say so. (At the moment there are only two, G_CONNECT_AFTER and G_CONNECT_SWAPPED - but if we'd have to write new code to support some hypothetical future G_CONNECT_CAFFEINATED flag, then we should document that G_C_A and G_C_S are the only supported flags.) How's this? Looks good to me. :) I bet having this comment in the docs would've helped before I discovered support for this flag was missing ;) Thanks, pushed. It'll be fixed in 0.11.3. This will also be fixed in 0.10.4; it's not applicable to 0.8. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.