Bug 27714 - tp_g_signal_connect_object: Support G_CONNECT_AFTER flag.
Summary: tp_g_signal_connect_object: Support G_CONNECT_AFTER flag.
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-04-17 01:48 UTC by Mike Ruprecht
Modified: 2010-04-20 05:15 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Mike Ruprecht 2010-04-17 01:48:47 UTC 
See summary.
Comment 1 Simon McVittie 2010-04-19 04:21:53 UTC 
Looks good, but if we only actually support certain GConnectFlags, the doc-comment should say so.

(At the moment there are only two, G_CONNECT_AFTER and G_CONNECT_SWAPPED - but if we'd have to write new code to support some hypothetical future G_CONNECT_CAFFEINATED flag, then we should document that G_C_A and G_C_S are the only supported flags.)
Comment 2 Simon McVittie 2010-04-19 04:28:53 UTC 
How's this?
Comment 3 Mike Ruprecht 2010-04-19 21:20:12 UTC 
Looks good to me. :)

I bet having this comment in the docs would've helped before I discovered support for this flag was missing ;)
Comment 4 Simon McVittie 2010-04-20 03:14:12 UTC 
Thanks, pushed. It'll be fixed in 0.11.3.
Comment 5 Simon McVittie 2010-04-20 05:15:48 UTC 
This will also be fixed in 0.10.4; it's not applicable to 0.8.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.