Bug 27773

Summary:	Make debug, util, datetime, action-chain be library-internal
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	logger	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	danielle, travis.reitter
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/telepathy-logger.git;a=shortlog;h=refs/heads/internalize
Whiteboard:	review+
i915 platform:		i915 features:
Bug Depends on:	27772
Bug Blocks:	27178, 27271

Description Simon McVittie 2010-04-21 07:19:45 UTC

See the branch:

http://git.collabora.co.uk/?p=user/smcv/telepathy-logger.git;a=shortlog;h=refs/heads/internalize

This partially solves Bug #27178.

I could use a -priv.h or -private.h suffix for the headers if you want, but I prefer -internal.h (as seen in telepathy-glib), since these things are really library-scoped, which doesn't correspond to C++ private at all (but does correspond almost exactly to G_GNUC_INTERNAL).

Comment 1 Cosimo Alfarano 2010-04-22 09:25:50 UTC

Most of the build infrasctucture was inherited from Empathy, that's why it differs a lot from TP.

in 962aa841b069db2619f4215a507891ff86d3fdcd

I'd enable also:

-#   declaration-after-statement \

unless you have specific reason to let it off.

For the rest, OK!

Comment 2 Cosimo Alfarano 2010-04-22 09:28:59 UTC

Ignore comment#2 which was for for another branch of yours, I remove the review+ for the moment.

Comment 3 Cosimo Alfarano 2010-04-23 10:17:51 UTC

It look good and it compiles against the current Empathy trunk.

Empathy though depends on TPL on a strict version basis, so it wouldn't break anything, it is just to know that it works.

I rebased a current big branch of mine on top of internalize and it seems working properly as well without big manual works.

You can merge it.

thank you.

Comment 4 Simon McVittie 2010-04-23 11:42:51 UTC

Thanks, merged.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.