Bug 27773 - Make debug, util, datetime, action-chain be library-internal
Summary: Make debug, util, datetime, action-chain be library-internal
Alias: None
Product: Telepathy
Classification: Unclassified
Component: logger (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard: review+
Keywords: patch
Depends on: 27772
Blocks: 27178 27271
  Show dependency treegraph
Reported: 2010-04-21 07:19 UTC by Simon McVittie
Modified: 2010-04-23 11:42 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Description Simon McVittie 2010-04-21 07:19:45 UTC
See the branch:


This partially solves Bug #27178.

I could use a -priv.h or -private.h suffix for the headers if you want, but I prefer -internal.h (as seen in telepathy-glib), since these things are really library-scoped, which doesn't correspond to C++ private at all (but does correspond almost exactly to G_GNUC_INTERNAL).
Comment 1 Cosimo Alfarano 2010-04-22 09:25:50 UTC
Most of the build infrasctucture was inherited from Empathy, that's why it differs a lot from TP.

in 962aa841b069db2619f4215a507891ff86d3fdcd

I'd enable also:

-#   declaration-after-statement \

unless you have specific reason to let it off.

For the rest, OK!
Comment 2 Cosimo Alfarano 2010-04-22 09:28:59 UTC
Ignore comment#2 which was for for another branch of yours, I remove the review+ for the moment.
Comment 3 Cosimo Alfarano 2010-04-23 10:17:51 UTC
It look good and it compiles against the current Empathy trunk.

Empathy though depends on TPL on a strict version basis, so it wouldn't break anything, it is just to know that it works.

I rebased a current big branch of mine on top of internalize and it seems working properly as well without big manual works.

You can merge it.

thank you.
Comment 4 Simon McVittie 2010-04-23 11:42:51 UTC
Thanks, merged.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.