Bug 28210

Summary:	[bisected r300g] Heroes of Newerth crash
Product:	Mesa	Reporter:	Pavel Ondračka <pavel.ondracka>
Component:	Drivers/DRI/r300	Assignee:	Default DRI bug account <dri-devel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	maraeo
Version:	git	Keywords:	regression
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	backtrace different crash

Description Pavel Ondračka 2010-05-22 01:39:40 UTC

Created attachment 35792 [details]
backtrace

With latest mesa git Heroes of Newerth crash early in game usually if some effect like when you gain level is rendered. This is a regression introduce by this commit:

f86ac27bf9203fdd9b7110dc843263307f475a99 is the first bad commit
commit f86ac27bf9203fdd9b7110dc843263307f475a99
Author: Marek Olšák <maraeo@gmail.com>
Date:   Sat May 15 22:55:17 2010 +0200

    r300g: fix psychedelic colors with SWTCL
    
    r300_vertex_shader::outputs was uninitialized.
    Also remove the tokens parameter.

Reverting mentioned commit solves this issue.

Comment 1 Pavel Ondračka 2010-05-22 01:44:03 UTC

Created attachment 35793 [details]
different crash

BTW when I was bisecting and head was at commit "r300g: fix emission of some non-CSO atoms at the beginning of CS" it also crashed (after longer time) but I did git bisect good, because this crash looks different.

Comment 2 Pavel Ondračka 2010-05-22 01:47:27 UTC

I forgot to mention my video card:
01:00.0 VGA compatible controller: ATI Technologies Inc M56P [Radeon Mobility X1600] (RV530)

Comment 3 Marek Olšák 2010-05-23 09:52:22 UTC

There are 2 issues:

1. Dummy vertex shader compilation was broken.

2. SIN and COS instructions haven't been implemented for vertex shaders. I am really surprised because I thought we had them. Nevertheless r300 supports them in HW directly (instructions ME_SIN and ME_COS) so their implementation should be straithforward.

'1' should be fixed. Can you please try current mesa git?

Comment 4 Pavel Ondračka 2010-05-23 11:29:24 UTC

HoN no longer crash with current mesa git. Thank you Marek.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.