Bug 28270

Summary: Remove libmcclient from mc-tool
Product: Telepathy Reporter: Danielle Madeley <danielle>
Component: mission-controlAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium CC: smcv
Version: unspecifiedKeywords: patch
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/danni/telepathy-mission-control.git;a=shortlog;h=refs/heads/mc-tool-remove-mcclient
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 24913    

Description Danielle Madeley 2010-05-26 21:50:45 UTC
+++ This bug was initially created as a clone of Bug #24913 +++

Remove usage of libmcclient from mc-tool.
Comment 1 Danielle Madeley 2010-05-26 21:54:03 UTC
This branch removes all references to libmcclient except for profiles.
Comment 2 Simon McVittie 2010-05-27 03:42:32 UTC
I didn't review "Change names of variables that shadow global functions", I assume that's the same as the one I just reviewed elsewhere.

> -    if (startswith (string, account_prefix))
> +    if (startswith (string, TP_ACCOUNT_OBJECT_PATH_BASE))

This could probably be g_str_has_prefix(), too?

> This reenables NormalizedName and AutomaticPresence by requesting those
> properties directly from the Account Manager, since they are not exposed
> via TpAccount.

File bugs? NormalizedName is not amazingly useful IMO, but AutomaticPresence could be.
Comment 3 Danielle Madeley 2010-05-27 04:03:24 UTC
Merged.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.