Bug 28270 - Remove libmcclient from mc-tool
Summary: Remove libmcclient from mc-tool
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/da...
Whiteboard:
Keywords: patch
Depends on:
Blocks: 24913
  Show dependency tree / graph
 
Reported: 2010-05-26 21:50 UTC by Danielle Madeley
Modified: 2010-05-27 04:03 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Danielle Madeley 2010-05-26 21:50:45 UTC 
+++ This bug was initially created as a clone of Bug #24913 +++

Remove usage of libmcclient from mc-tool.
Comment 1 Danielle Madeley 2010-05-26 21:54:03 UTC 
This branch removes all references to libmcclient except for profiles.
Comment 2 Simon McVittie 2010-05-27 03:42:32 UTC 
I didn't review "Change names of variables that shadow global functions", I assume that's the same as the one I just reviewed elsewhere.

> -    if (startswith (string, account_prefix))
> +    if (startswith (string, TP_ACCOUNT_OBJECT_PATH_BASE))

This could probably be g_str_has_prefix(), too?

> This reenables NormalizedName and AutomaticPresence by requesting those
> properties directly from the Account Manager, since they are not exposed
> via TpAccount.

File bugs? NormalizedName is not amazingly useful IMO, but AutomaticPresence could be.
Comment 3 Danielle Madeley 2010-05-27 04:03:24 UTC 
Merged.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.