Summary: | [r300, r600] celestia core dumps - Assertion `dstRowStride' failed. | ||
---|---|---|---|
Product: | Mesa | Reporter: | Chris Rankin <rankincj> |
Component: | Drivers/DRI/r300 | Assignee: | Default DRI bug account <dri-devel> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | medium | CC: | randrik |
Version: | git | ||
Hardware: | x86 (IA32) | ||
OS: | Linux (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | Alternate patch for mipmap HW generation |
Description
Chris Rankin
2010-05-27 13:07:54 UTC
Is this a recent regression? If so, can you bisect it? I suspect one of the recent mipmap patches if so. (In reply to comment #1) > Is this a recent regression? If so, can you bisect it? I suspect one of the > recent mipmap patches if so. My (admitted limited) git-fu says: a9ee95651131e27d5acf3d10909b5b7e5c8d3e92 is the first bad commit commit a9ee95651131e27d5acf3d10909b5b7e5c8d3e92 Author: Will Dyson <will.dyson@gmail.com> Date: Tue May 25 01:10:20 2010 -0400 Fix image_matches_texture_obj() MaxLevel check When generating or uploading a new (higher) mipmap level for an image, we can need to allocate a miptree for a level greater than texObj->MaxLevel. Signed-off-by: Maciej Cencora <m.cencora@gmail.com> Signed-off-by: Alex Deucher <alexdeucher@gmail.com> :040000 040000 4e72a3914fd8572238c211c806b19d274557d5a9 ff974b144171e820cf2c22af344905ba62dcd446 M src (In reply to comment #2) > (In reply to comment #1) > > Is this a recent regression? If so, can you bisect it? I suspect one of the > > recent mipmap patches if so. > > My (admitted limited) git-fu says: > > a9ee95651131e27d5acf3d10909b5b7e5c8d3e92 is the first bad commit > commit a9ee95651131e27d5acf3d10909b5b7e5c8d3e92 > Author: Will Dyson <will.dyson@gmail.com> > Date: Tue May 25 01:10:20 2010 -0400 Crap. The driver really does allocate memory based on the maxlevel of the texture object. I've got an alternate patch though... Created attachment 35898 [details] [review] Alternate patch for mipmap HW generation Contains a revert of the bad changes (In reply to comment #4) > Created an attachment (id=35898) [details] > Alternate patch for mipmap HW generation > > Contains a revert of the bad changes Were people waiting on me to test this patch? (Couldn't anyone else reproduce the problem?) "Yes, it fixes it. Thanks." Please commit this patch to Git repository. I know this is temporary fix, but if it is such a bad regression (and it is bad regression, at least for me Celestia is really important software), the bad change which causes it should be reverted immediately till the proper fix is released. Fix pushed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.