Bug 28636

Summary: missing TV parameter "Dot Crawl freeze"
Product: DRI Reporter: Gordon Jin <gordon.jin>
Component: DRM/IntelAssignee: Paulo Zanoni <przanoni>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: medium    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Gordon Jin 2010-06-20 19:56:55 UTC
"Dot Crawl freeze" is not implemented in the driver.

Below is the SDVO-TV output of "xrandr --verbose", with ADD2 card on G45, with
2.6.34 kernel:

TV1 unknown connection 1024x768+0+0 (0x44) normal (normal left inverted right x
axis y axis) 0mm x 0mm
    Identifier: 0x43
    Timestamp:  201719
    Subpixel:   horizontal rgb
    Gamma:      1.0:1.0:1.0
    Brightness: 1.0
    Clones:    
    CRTC:       0
    CRTCs:      0 1
    Transform:  1.000000 0.000000 0.000000
                0.000000 1.000000 0.000000
                0.000000 0.000000 1.000000
               filter: 
    brightness: 128 (0x00000080)    range:  (0,255)
    hue: 64 (0x00000040)    range:  (0,127)
    contrast: 64 (0x00000040)    range:  (0,127)
    saturation: 69 (0x00000045)    range:  (0,127)
    vpos: 512 (0x00000200)    range:  (0,1023)
    hpos: 512 (0x00000200)    range:  (0,1023)
    bottom_margin: 15 (0x0000000f)    range:  (0,47)
    top_margin: 15 (0x0000000f)    range:  (0,47)
    right_margin: 15 (0x0000000f)    range:  (0,47)
    left_margin: 15 (0x0000000f)    range:  (0,47)
    mode:    NTSC_M
        supported: NTSC_M       NTSC_J       NTSC_443     PAL_B       
                   PAL_D        PAL_G        PAL_H        PAL_I       
                   PAL_M        PAL_N        PAL_NC       PAL_60      
                   SECAM_B      SECAM_D      SECAM_G      SECAM_K     
                   SECAM_K1     SECAM_L      SECAM_60    
  1024x768 (0x44)   65.0MHz -HSync -VSync *current
        h: width  1024 start 1048 end 1184 total 1344 skew    0 clock   48.4KHz
        v: height  768 start  771 end  777 total  806           clock   60.0Hz
  800x600 (0x45)   40.0MHz +HSync +VSync
        h: width   800 start  840 end  968 total 1056 skew    0 clock   37.9KHz
        v: height  600 start  601 end  605 total  628           clock   60.3Hz
  800x600 (0x46)   36.0MHz +HSync +VSync
        h: width   800 start  824 end  896 total 1024 skew    0 clock   35.2KHz
        v: height  600 start  601 end  603 total  625           clock   56.2Hz
  848x480 (0x47)   33.8MHz +HSync +VSync
        h: width   848 start  864 end  976 total 1088 skew    0 clock   31.0KHz
        v: height  480 start  486 end  494 total  517           clock   60.0Hz
  640x480 (0x48)   25.2MHz -HSync -VSync
        h: width   640 start  656 end  752 total  800 skew    0 clock   31.5KHz
        v: height  480 start  489 end  492 total  525           clock   59.9Hz
  640x480 (0x49)   25.2MHz -HSync -VSync
        h: width   640 start  656 end  752 total  800 skew    0 clock   31.5KHz
        v: height  480 start  490 end  492 total  525           clock   59.9Hz
Comment 1 Chris Wilson 2010-07-18 12:04:01 UTC
For reference, the work-in-progress tree is at http://cgit.freedesktop.org/~ickle/linux-2.6/log/?h=sdvo 

commit 5cb6a67a59f0ad645a7925e0c26728093d460233
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Sun Jul 18 20:01:36 2010 +0100

    drm/i915/sdvo: Add dot crawl property
    
    This property is slightly unusual in that it is a boolean and so has no
    GET_MAX command.
    
    Reference:
    
      Bug 28636 - missing TV parameter "Dot Crawl freeze"
      https://bugs.freedesktop.org/show_bug.cgi?id=28636
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Comment 2 Chris Wilson 2010-08-06 15:07:19 UTC
Applied to Eric's for-linus branch.
Comment 3 madbiologist 2010-08-24 00:05:16 UTC
The abovementioned patch is included in kernel 2.6.36-rc2.
Comment 4 bo.b.wang 2011-06-08 18:29:39 UTC
"Dot Crawl freeze" is still not implemented in the driver 2.6.36-rc2.

TV1 connected 1024x768+0+0 (0x46) normal (normal left inverted right x axis y axis) 0mm x 0mm
	Identifier: 0x42
	Timestamp:  36368
	Subpixel:   horizontal rgb
	Gamma:      1.0:1.0:1.0
	Brightness: 1.0
	Clones:     VGA1 VGA2
	CRTC:       0
	CRTCs:      0 1
	Transform:  1.000000 0.000000 0.000000
	            0.000000 1.000000 0.000000
	            0.000000 0.000000 1.000000
	           filter: 
	tv_chroma_filter: 1 (0x00000001)	range:  (0,3)
	flicker_filter_adaptive: 7 (0x00000007)	range:  (0,7)
	brightness: 128 (0x00000080)	range:  (0,255)
	sharpness: 4 (0x00000004)	range:  (0,7)
	hue: 64 (0x00000040)	range:  (0,127)
	contrast: 64 (0x00000040)	range:  (0,127)
	saturation: 69 (0x00000045)	range:  (0,127)
	vpos: 512 (0x00000200)	range:  (0,1023)
	hpos: 512 (0x00000200)	range:  (0,1023)
	bottom_margin: 15 (0x0000000f)	range:  (0,47)
	top_margin: 15 (0x0000000f)	range:  (0,47)
	right_margin: 15 (0x0000000f)	range:  (0,47)
	left_margin: 15 (0x0000000f)	range:  (0,47)
	mode:	NTSC_M
		supported: NTSC_M       NTSC_J       NTSC_443     PAL_B       
		           PAL_D        PAL_G        PAL_H        PAL_I       
		           PAL_M        PAL_N        PAL_NC       PAL_60      
		           SECAM_B      SECAM_D      SECAM_G      SECAM_K     
		           SECAM_K1     SECAM_L      SECAM_60    
  1280x1024 (0x45)   87.3MHz +HSync +VSync
        h: width  1280 start 1281 end 1344 total 1376 skew    0 clock   63.4KHz
        v: height 1024 start 1025 end 1056 total 1057           clock   60.0Hz
  1024x768 (0x46)   53.8MHz +HSync +VSync *current
        h: width  1024 start 1025 end 1088 total 1120 skew    0 clock   48.1KHz
        v: height  768 start  769 end  800 total  801           clock   60.0Hz
  920x766 (0x47)   48.7MHz +HSync +VSync
        h: width   920 start  921 end  984 total 1016 skew    0 clock   47.9KHz
        v: height  766 start  767 end  798 total  799           clock   60.0Hz
  832x624 (0x48)   36.6MHz +HSync +VSync
        h: width   832 start  833 end  896 total  928 skew    0 clock   39.4KHz
        v: height  624 start  625 end  656 total  657           clock   60.0Hz
  800x600 (0x49)   34.0MHz +HSync +VSync
        h: width   800 start  801 end  864 total  896 skew    0 clock   38.0KHz
        v: height  600 start  601 end  632 total  633           clock   60.0Hz
  768x576 (0x4a)   31.6MHz +HSync +VSync
        h: width   768 start  769 end  832 total  864 skew    0 clock   36.5KHz
        v: height  576 start  577 end  608 total  609           clock   60.0Hz
  720x576 (0x4b)   29.8MHz +HSync +VSync
        h: width   720 start  721 end  784 total  816 skew    0 clock   36.5KHz
        v: height  576 start  577 end  608 total  609           clock   60.0Hz
  704x576 (0x4c)   29.2MHz +HSync +VSync
        h: width   704 start  705 end  768 total  800 skew    0 clock   36.5KHz
        v: height  576 start  577 end  608 total  609           clock   60.0Hz
  720x540 (0x4d)   28.1MHz +HSync +VSync
        h: width   720 start  721 end  784 total  816 skew    0 clock   34.4KHz
        v: height  540 start  541 end  572 total  573           clock   60.0Hz
  720x480 (0x4e)   25.1MHz +HSync +VSync
        h: width   720 start  721 end  784 total  816 skew    0 clock   30.8KHz
        v: height  480 start  481 end  512 total  513           clock   60.0Hz
Comment 5 Daniel Vetter 2012-11-06 11:21:40 UTC
Afaik it _is_ implemented. Note that you need and SDVO TV interface card that actually supports it. The one in the xrandr dump doesn't have any advanced TV properties, so it likely doesn't have the "dot crawl freeze" property either.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.