| Summary: | Bind Account.Service | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Andre Moreira Magalhaes <andrunko> |
| Component: | tp-qt | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/andrunko/telepathy-qt4.git;a=shortlog;h=refs/heads/account-service | ||
| Whiteboard: | r+ | ||
| i915 platform: | i915 features: | ||
| Bug Depends on: | 28812, 28850 | ||
| Bug Blocks: | |||
|
Description
Andre Moreira Magalhaes
2010-06-29 18:17:55 UTC
I think the getter ought to fall back to the protocol name. In any case, this shouldn't be merged until you merge a spec release that has Service :-) (In reply to comment #1) > I think the getter ought to fall back to the protocol name. Done > In any case, this shouldn't be merged until you merge a spec release that has > Service :-) By you, you mean me? hehe. I am waiting for a spec release to release this :D I think the fallback to protocol name should be documented, because it differs from the spec. And it'd be nice if there were a test. Otherwise looks good! (In reply to comment #3) > I think the fallback to protocol name should be documented, because it differs > from the spec. > > And it'd be nice if there were a test. > > Otherwise looks good! Pushed an updated doc for serviceName() and add a test for it. ship it! Merged upstream. It will be in next release 0.3.6. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.