Bug 28825 - Bind Account.Service
Summary: Bind Account.Service
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-qt (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/an...
Whiteboard: r+
Keywords: patch
Depends on: 28812 28850
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-29 18:17 UTC by Andre Moreira Magalhaes
Modified: 2010-07-01 09:12 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Andre Moreira Magalhaes 2010-06-29 18:17:55 UTC

    
Comment 1 Simon McVittie 2010-06-30 03:42:24 UTC
I think the getter ought to fall back to the protocol name.

In any case, this shouldn't be merged until you merge a spec release that has Service :-)
Comment 2 Andre Moreira Magalhaes 2010-06-30 05:49:04 UTC
(In reply to comment #1)
> I think the getter ought to fall back to the protocol name.
Done
 
> In any case, this shouldn't be merged until you merge a spec release that has
> Service :-)
By you, you mean me? hehe. I am waiting for a spec release to release this :D
Comment 3 Will Thompson 2010-07-01 08:06:12 UTC
I think the fallback to protocol name should be documented, because it differs from the spec.

And it'd be nice if there were a test.

Otherwise looks good!
Comment 4 Andre Moreira Magalhaes 2010-07-01 08:47:48 UTC
(In reply to comment #3)
> I think the fallback to protocol name should be documented, because it differs
> from the spec.
> 
> And it'd be nice if there were a test.
> 
> Otherwise looks good!

Pushed an updated doc for serviceName() and add a test for it.
Comment 5 Will Thompson 2010-07-01 09:10:07 UTC
ship it!
Comment 6 Andre Moreira Magalhaes 2010-07-01 09:12:35 UTC
Merged upstream. It will be in next release 0.3.6.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.