Bug 28894

Summary:	slang build fails if absolute path contains spaces
Product:	Mesa	Reporter:	nobled <nobled>
Component:	Mesa core	Assignee:	nobled <nobled>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	nobled
Version:	git
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	wrap absolute path in quotes wrap absolute paths in quotes v2

Description nobled 2010-07-02 15:41:12 UTC

Compiling on Windows with "scons statetrackers=mesa drivers=softpipe winsys=gdi" failed when it tried to run compile.exe:

C:\Documents and Settings\[...]\mesa\build\windows-x86-debug-glsl\compile.exe fragment src\mesa\slang\library\slang_common_builtin.gc src\mesa\slang\library\slang_common_builtin_gc.h
'C:\Documents' is not recognized as an internal or external command, operable program or batch file.
scons: *** [src\mesa\slang\library\slang_common_builtin_gc.h] Error 1
scons: building terminated because of errors.

The problem looks like it starts in library/SConscript:

bld_frag = Builder(
	action = Action(glsl_compile[0].abspath + ' fragment $SOURCE $TARGET', '$CODEGENCODESTR'),
	emitter = glsl_compile_emitter,
	suffix = '.gc',
	src_suffix = '_gc.h')

Comment 1 nobled 2010-07-06 12:26:20 UTC

Created attachment 36789 [details] [review]
wrap absolute path in quotes

FTR, this is a regression on 3371f7e5025e5288eaba78973a2c81ec5d5b1e4d. (Is the abspath really necessary?)

Comment 2 nobled 2010-07-15 12:58:43 UTC

Created attachment 37086 [details] [review]
wrap absolute paths in quotes v2

Comment 3 Eric Anholt 2010-08-25 17:36:32 UTC

Slang is gone.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.