Bug 28920

Summary:	Connect cancellable earlier in tp_contact_request_contact_info_async()
Product:	Telepathy	Reporter:	Philip Withnall <bugzilla>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:	review+
i915 platform:		i915 features:
Attachments:	Connect cancellable earlier in tp_contact_request_contact_info_async() Connect cancellable earlier in tp_contact_request_contact_info_async() Rework cancellable handling in tp_contact_request_contact_info_async()

Description Philip Withnall 2010-07-05 09:30:48 UTC

Created attachment 36764 [details] [review]
Connect cancellable earlier in tp_contact_request_contact_info_async()

Patch attached to connect the cancellable earlier in tp_contact_request_contact_info_async(), since otherwise it's useless, and the callback function could quite easily assume it can free the cancellable, yet doing so would cause a crash.

Comment 1 Jonny Lamb 2010-07-06 02:38:01 UTC

YES GOG OGGOGOGOGOGO

Comment 2 Philip Withnall 2010-07-06 03:08:30 UTC

Created attachment 36783 [details] [review]
Connect cancellable earlier in tp_contact_request_contact_info_async()

Take 2.

Comment 3 Philip Withnall 2010-07-06 03:37:42 UTC

Created attachment 36784 [details] [review]
Rework cancellable handling in tp_contact_request_contact_info_async()

Take 3, now with less complexity.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.