Bug 28920 - Connect cancellable earlier in tp_contact_request_contact_info_async()
Summary: Connect cancellable earlier in tp_contact_request_contact_info_async()
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard: review+
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-05 09:30 UTC by Philip Withnall
Modified: 2010-07-07 10:59 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Connect cancellable earlier in tp_contact_request_contact_info_async() (1.47 KB, patch)
2010-07-05 09:30 UTC, Philip Withnall 		Details | Splinter Review
Connect cancellable earlier in tp_contact_request_contact_info_async() (2.02 KB, patch)
2010-07-06 03:08 UTC, Philip Withnall 		Details | Splinter Review
Rework cancellable handling in tp_contact_request_contact_info_async() (4.60 KB, patch)
2010-07-06 03:37 UTC, Philip Withnall 		Details | Splinter Review
Show Obsolete (2) View All

Description Philip Withnall 2010-07-05 09:30:48 UTC 
Created attachment 36764 [details] [review]
Connect cancellable earlier in tp_contact_request_contact_info_async()

Patch attached to connect the cancellable earlier in tp_contact_request_contact_info_async(), since otherwise it's useless, and the callback function could quite easily assume it can free the cancellable, yet doing so would cause a crash.
Comment 1 Jonny Lamb 2010-07-06 02:38:01 UTC 
YES GOG OGGOGOGOGOGO
Comment 2 Philip Withnall 2010-07-06 03:08:30 UTC 
Created attachment 36783 [details] [review]
Connect cancellable earlier in tp_contact_request_contact_info_async()

Take 2.
Comment 3 Philip Withnall 2010-07-06 03:37:42 UTC 
Created attachment 36784 [details] [review]
Rework cancellable handling in tp_contact_request_contact_info_async()

Take 3, now with less complexity.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.