Bug 28947

Summary: Account::filterAccounts doc does not properly format the example code
Product: Telepathy Reporter: Andre Moreira Magalhaes <andrunko>
Component: tp-qtAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard: r+
i915 platform: i915 features:

Description Andre Moreira Magalhaes 2010-07-07 10:25:43 UTC
The example code in Account::filterAccounts doc is not properly formatted. Also improve the example code to show how to use the method.
Comment 1 Will Thompson 2010-07-07 10:39:02 UTC
This isn't really right — you need to prepare 'am' first, no? So you can't just use the result of AM::create().

And maybe it should also include connecting to the signals on AccountSet? Just so the API user knows they're there.
Comment 2 Andre Moreira Magalhaes 2010-07-07 10:54:05 UTC
(In reply to comment #1)
> This isn't really right — you need to prepare 'am' first, no? So you can't just
> use the result of AM::create().
> 
> And maybe it should also include connecting to the signals on AccountSet? Just
> so the API user knows they're there.

True, updated doc to indicate AM needs to be ready first. Also included a ref to AccountSet doc that I am working at now. Used push -f ;)
Comment 3 Will Thompson 2010-07-07 12:56:31 UTC
Looks good
Comment 4 Andre Moreira Magalhaes 2010-07-15 14:26:16 UTC
Merged upstream. It will be in next release 0.3.8.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.