Bug 28947 - Account::filterAccounts doc does not properly format the example code
Summary: Account::filterAccounts doc does not properly format the example code
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-qt (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard: r+
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 10:25 UTC by Andre Moreira Magalhaes
Modified: 2010-07-15 16:57 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Andre Moreira Magalhaes 2010-07-07 10:25:43 UTC
The example code in Account::filterAccounts doc is not properly formatted. Also improve the example code to show how to use the method.
Comment 1 Will Thompson 2010-07-07 10:39:02 UTC
This isn't really right — you need to prepare 'am' first, no? So you can't just use the result of AM::create().

And maybe it should also include connecting to the signals on AccountSet? Just so the API user knows they're there.
Comment 2 Andre Moreira Magalhaes 2010-07-07 10:54:05 UTC
(In reply to comment #1)
> This isn't really right — you need to prepare 'am' first, no? So you can't just
> use the result of AM::create().
> 
> And maybe it should also include connecting to the signals on AccountSet? Just
> so the API user knows they're there.

True, updated doc to indicate AM needs to be ready first. Also included a ref to AccountSet doc that I am working at now. Used push -f ;)
Comment 3 Will Thompson 2010-07-07 12:56:31 UTC
Looks good
Comment 4 Andre Moreira Magalhaes 2010-07-15 14:26:16 UTC
Merged upstream. It will be in next release 0.3.8.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.