Bug 28985

Summary:	Use real enums in messages.h and draw.h
Product:	Spice	Reporter:	Alexander Larsson <alexl>
Component:	spicec (deprecated)	Assignee:	Spice Bug List <spice-bugs>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Initial patch patch updated to apply against current master

Description Alexander Larsson 2010-07-09 08:13:12 UTC

Created attachment 36919 [details] [review]
Initial patch

For the cases where messages have enums we should use the C enum types internally, rather than e.g. uint16_t. This way we get some typesafety from the compiler and the code becomes easier to read.

I made an initial pass on this but it needs some fixes in the code generator to not get type mismatch warnings.

Comment 1 Christophe Fergeau 2011-04-15 04:53:39 UTC

Created attachment 45660 [details] [review]
patch updated to apply against current master

Comment 2 Victor Toso 2015-06-19 17:31:05 UTC

nowhere to apply this with spicec deprecated

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.