Bug 29051

Summary:	Configuration reload on every query
Product:	PolicyKit	Reporter:	Petr Mrázek <peterix>
Component:	daemon	Assignee:	David Zeuthen (not reading bugmail) <zeuthen>
Status:	RESOLVED FIXED	QA Contact:	David Zeuthen (not reading bugmail) <zeuthen>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch to set has_data to true when configuration is loaded

Description Petr Mrázek 2010-07-13 18:10:22 UTC

Created attachment 37006 [details] [review]
Patch to set has_data to true when configuration is loaded

Basically, has_data was never set to TRUE, causing the backend to reload data on each request to the local authority. It seems to be a simple omission.

Patch is enclosed.

Comment 1 David Zeuthen (not reading bugmail) 2010-07-15 07:02:56 UTC

Hey - thanks for the patch. The patch looks good except the 'has_data = TRUE' assignment in polkitbackendlocalauthorizationstore.c needs to happen a bit later so we also properly set it for empty directories. I'll commit a patch with that fix. Thanks.

Comment 2 David Zeuthen (not reading bugmail) 2010-07-15 07:03:56 UTC

This is the patch I committed

http://cgit.freedesktop.org/PolicyKit/commit/?id=779c0153fc0bd3c2e302dac1979d17638f054229

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.