Bug 29051 - Configuration reload on every query
Summary: Configuration reload on every query
Status: RESOLVED FIXED
Alias: None
Product: PolicyKit
Classification: Unclassified
Component: daemon (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: David Zeuthen (not reading bugmail)
QA Contact: David Zeuthen (not reading bugmail)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-13 18:10 UTC by Petr Mrázek
Modified: 2010-07-15 07:03 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch to set has_data to true when configuration is loaded (1.54 KB, patch)
2010-07-13 18:10 UTC, Petr Mrázek
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Mrázek 2010-07-13 18:10:22 UTC
Created attachment 37006 [details] [review]
Patch to set has_data to true when configuration is loaded

Basically, has_data was never set to TRUE, causing the backend to reload data on each request to the local authority. It seems to be a simple omission.

Patch is enclosed.
Comment 1 David Zeuthen (not reading bugmail) 2010-07-15 07:02:56 UTC
Hey - thanks for the patch. The patch looks good except the 'has_data = TRUE' assignment in polkitbackendlocalauthorizationstore.c needs to happen a bit later so we also properly set it for empty directories. I'll commit a patch with that fix. Thanks.
Comment 2 David Zeuthen (not reading bugmail) 2010-07-15 07:03:56 UTC
This is the patch I committed

http://cgit.freedesktop.org/PolicyKit/commit/?id=779c0153fc0bd3c2e302dac1979d17638f054229


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct.