Bug 29120

Summary:	test/get-clip.c does not report failures
Product:	cairo	Reporter:	Karl Tomlinson <bugs.freedesktop>
Component:	general	Assignee:	Karl Tomlinson <bugs.freedesktop>
Status:	RESOLVED FIXED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	normal
Priority:	medium
Version:	1.9.13
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:	29121, 29122
Bug Blocks:
Attachments:	patch

Description Karl Tomlinson 2010-07-16 14:58:47 UTC

Since
http://cgit.freedesktop.org/cairo/commit/?id=336eddfdbb31865e3669ceb775089c63ce1db27f
get-clip.c has not returned CAIRO_TEST_FAILURE for failures in its own
explicit tests.
(I'll attach a patch shortly.)

Comment 1 Karl Tomlinson 2010-07-16 15:51:34 UTC

Created attachment 37142 [details] [review]
patch

Comment 2 Karl Tomlinson 2010-07-16 15:53:07 UTC

To make the test pass the patches in bug 29121 and bug 29122 will be needed.

Comment 3 Chris Wilson 2010-07-17 02:29:30 UTC

Karl, do you mind replacing these patches with ones generated by git format-patch?

Comment 4 Chris Wilson 2010-07-17 03:33:47 UTC

commit 6a5115901381fe9c81a8a311e267c2a00e2a1d04
Author: Karl Tomlinson <karlt+@karlt.net>
Date:   Sat Jul 17 10:47:42 2010 +1200

    test: return CAIRO_TEST_FAILURE from get-clip preamble on failure
    
    https://bugs.freedesktop.org/show_bug.cgi?id=29120

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.