| Summary: | [PATCH] tp-glib shouldn't rely upon vala-1.0.pc for its bindings | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Travis Reitter <travis.reitter> |
| Component: | tp-glib | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | cosimoc |
| Version: | git master | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/vala-pc-fixes | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Travis Reitter
2010-08-12 09:25:44 UTC
This branch should fix the problem. I tested it with every combination of [automake 1.11 installed, not installed] X [vala < 0.9.5 installed, vala 0.9.5 installed] as well as without --enable-vala-bindings, and they all seemed to behave as they should. > + AC_PATH_PROG([VAPIGEN], [vapigen], [false])
>
> if test "x$VAPIGEN" = "x"; then
You now need to check against "false":
if test "x$VAPIGEN" = xfalse; then
With that change, r+.
I take it back: this did need a bit more work. I've branched your branch :-) I reduced the Vala dependency back to 0.9.3, because to the best of my knowledge the only reason you were depending on 0.9.5 was to get the .pc file that you no longer use anyway... (In reply to comment #3) > I take it back: this did need a bit more work. I've branched your branch :-) > > I reduced the Vala dependency back to 0.9.3, because to the best of my > knowledge the only reason you were depending on 0.9.5 was to get the .pc file > that you no longer use anyway... Looks and works well for me. Please merge. Fixed in git for 0.11.13 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.