Bug 29534 - [PATCH] tp-glib shouldn't rely upon vala-1.0.pc for its bindings
Summary: [PATCH] tp-glib shouldn't rely upon vala-1.0.pc for its bindings
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-08-12 09:25 UTC by Travis Reitter
Modified: 2010-08-13 08:25 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Travis Reitter 2010-08-12 09:25:44 UTC
The vala-1.0.pc file is only meant for users of libvala (ie, valac and other core tools themselves). So we need to detect the existence and version of Vala through other means.
Comment 1 Travis Reitter 2010-08-12 09:28:42 UTC
This branch should fix the problem. I tested it with every combination of [automake 1.11 installed, not installed] X [vala < 0.9.5 installed, vala 0.9.5 installed] as well as without --enable-vala-bindings, and they all seemed to behave as they should.
Comment 2 Simon McVittie 2010-08-13 02:56:29 UTC
> +  AC_PATH_PROG([VAPIGEN], [vapigen], [false])
>  
>    if test "x$VAPIGEN" = "x"; then

You now need to check against "false":

    if test "x$VAPIGEN" = xfalse; then

With that change, r+.
Comment 3 Simon McVittie 2010-08-13 07:47:03 UTC
I take it back: this did need a bit more work. I've branched your branch :-)

I reduced the Vala dependency back to 0.9.3, because to the best of my knowledge the only reason you were depending on 0.9.5 was to get the .pc file that you no longer use anyway...
Comment 4 Travis Reitter 2010-08-13 08:23:41 UTC
(In reply to comment #3)
> I take it back: this did need a bit more work. I've branched your branch :-)
> 
> I reduced the Vala dependency back to 0.9.3, because to the best of my
> knowledge the only reason you were depending on 0.9.5 was to get the .pc file
> that you no longer use anyway...

Looks and works well for me. Please merge.
Comment 5 Simon McVittie 2010-08-13 08:25:54 UTC
Fixed in git for 0.11.13


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.