Bug 29783

Summary:	[regression] No light in Ambient aperture lighting demo
Product:	Mesa	Reporter:	Sven Arvidsson <sa>
Component:	Mesa core	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	git
Hardware:	Other
OS:	All
URL:	http://www.humus.name/index.php?page=3D&ID=71
Whiteboard:
i915 platform:		i915 features:

Description Sven Arvidsson 2010-08-24 10:50:56 UTC

The glsl2 merge introduced a regression in Humus Ambient Aperture Lighting demo. The light is not rendered, leaving the scene dark.

All shaders report compile status ok.

http://www.humus.name/index.php?page=3D&ID=71

Comment 1 Eric Anholt 2010-08-25 16:46:08 UTC

commit b2872ea353efd117fcc4d22f0ca66a26f95a14c4
Author: Eric Anholt <eric@anholt.net>
Date:   Wed Aug 25 16:38:37 2010 -0700

    Revert "mesa: Don't add 1 to GL_ACTIVE_UNIFORM_MAX_LENGTH."
    
    This reverts commit 001a7bfdfc8b3c8930d5ced21982dbdfb8cd35b3.  I
    hadn't found the section of the spec clarifying that the old behavior
    was right.  Reverting fixes the new version of the testcase, and the
    Humus demos that could no longer find their uniforms.
    
    Bug #29782
    Bug #29783

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.