Bug 30599

Summary: tslib fallback check doesn't set TSLIB_LIBS
Product: xorg Reporter: Michał Górny <mgorny>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: git   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Ensure that TSLIB_LIBS is set even if pkg-config fails
none
The failing build log (just for reference) none

Description Michał Górny 2010-10-04 10:22:54 UTC 
Created attachment 39155 [details] [review]
Ensure that TSLIB_LIBS is set even if pkg-config fails

If the pkg-config check for tslib fails but the fallback AC_CHECK_LIB() succeeds, the xorg-server build attempt fails with unresolved library references. The reason for that is that TSLIB_LIBS is unset (that variable is supposed to be set by PKG_CHECK_MODULES()).

I'm attaching a patch which sets TSLIB_LIBS as necessary if the fallback AC_CHECK_LIB() succeeds.
Comment 1 Michał Górny 2010-10-04 10:23:30 UTC 
Created attachment 39156 [details]
The failing build log (just for reference)
Comment 2 Julien Cristau 2010-10-04 10:46:16 UTC 
On Mon, Oct  4, 2010 at 10:22:54 -0700, bugzilla-daemon@freedesktop.org wrote:

> I'm attaching a patch which sets TSLIB_LIBS as necessary if the fallback
> AC_CHECK_LIB() succeeds.
> 
Note that that code is likely to get removed before 1.10:
http://lists.x.org/pipermail/xorg-devel/2010-July/010983.html
Comment 3 Adam Jackson 2018-04-23 21:26:08 UTC 
tslib support is gone.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.