Bug 30599 - tslib fallback check doesn't set TSLIB_LIBS
tslib fallback check doesn't set TSLIB_LIBS
Status: NEW
Product: xorg
Classification: Unclassified
Component: Server/General
git
All Linux (All)
: medium normal
Assigned To: Xorg Project Team
Xorg Project Team
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-04 10:22 UTC by Michał Górny
Modified: 2010-10-04 10:46 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Ensure that TSLIB_LIBS is set even if pkg-config fails (1.09 KB, patch)
2010-10-04 10:22 UTC, Michał Górny
no flags Details | Splinter Review
The failing build log (just for reference) (66.79 KB, text/plain)
2010-10-04 10:23 UTC, Michał Górny
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny 2010-10-04 10:22:54 UTC
Created attachment 39155 [details] [review]
Ensure that TSLIB_LIBS is set even if pkg-config fails

If the pkg-config check for tslib fails but the fallback AC_CHECK_LIB() succeeds, the xorg-server build attempt fails with unresolved library references. The reason for that is that TSLIB_LIBS is unset (that variable is supposed to be set by PKG_CHECK_MODULES()).

I'm attaching a patch which sets TSLIB_LIBS as necessary if the fallback AC_CHECK_LIB() succeeds.
Comment 1 Michał Górny 2010-10-04 10:23:30 UTC
Created attachment 39156 [details]
The failing build log (just for reference)
Comment 2 Julien Cristau 2010-10-04 10:46:16 UTC
On Mon, Oct  4, 2010 at 10:22:54 -0700, bugzilla-daemon@freedesktop.org wrote:

> I'm attaching a patch which sets TSLIB_LIBS as necessary if the fallback
> AC_CHECK_LIB() succeeds.
> 
Note that that code is likely to get removed before 1.10:
http://lists.x.org/pipermail/xorg-devel/2010-July/010983.html