| Summary: | Windows portability patches for gabble | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Thomas Flüeli <tflueeli> |
| Component: | gabble | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | 0.10 | ||
| Hardware: | Other | ||
| OS: | Windows (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
patch 1
patch 2 patch 3 patch 4 patch 5 |
||
|
Description
Thomas Flüeli
2010-10-28 07:20:54 UTC
Created attachment 39849 [details] [review] patch 1 Created attachment 39850 [details] [review] patch 2 Created attachment 39851 [details] [review] patch 3 Created attachment 39852 [details] [review] patch 4 Created attachment 39853 [details] [review] patch 5 Review of attachment 39849 [details] [review]: Does Windows really not have u_intNN_t? But, OK. Review of attachment 39850 [details] [review]: > cannot convert from 'GDebugKey' to 'GDebugKey' Comedy. The cast is unnecessary, though, so we might as well remove it. Review of attachment 39851 [details] [review]: Sure, looks good. Review of attachment 39852 [details] [review]: I'm sure I already implemented this... oh, but that was in telepathy-glib, and Bug #26516 prevents using it. :-( Your patch looks fine. Review of attachment 39853 [details] [review]: Looks good. Review of attachment 39853 [details] [review]: Looks good. Thanks, I've merged all five patches in git (to the telepathy-gabble-0.10 and master branches). Fixed in Gabble 0.10.4 and 0.11.0, when those versions are released. Review of attachment 39849 [details] [review]: On windows they are called uint* (without underscore) for unknown reason, so it's better to use glib type indeed. (In reply to comment #13) > On windows they are called uint* (without underscore) for unknown reason, so > it's better to use glib type indeed. On closer inspection, uintNN_t is ISO, whereas u_intNN_t is non-standard (but is defined by sys/types.h on Linux, and for some reason gets syntax-highlit as a constant in vim, which uintNN_t does not). |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.