Bug 31197 - Windows portability patches for gabble
Summary: Windows portability patches for gabble
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: 0.10
Hardware: Other Windows (All)
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-10-28 07:20 UTC by Thomas Flüeli
Modified: 2010-10-28 11:20 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch 1 (879 bytes, patch)
2010-10-28 07:21 UTC, Thomas Flüeli 		Details | Splinter Review
patch 2 (814 bytes, patch)
2010-10-28 07:22 UTC, Thomas Flüeli 		Details | Splinter Review
patch 3 (685 bytes, patch)
2010-10-28 07:22 UTC, Thomas Flüeli 		Details | Splinter Review
patch 4 (1.07 KB, patch)
2010-10-28 07:23 UTC, Thomas Flüeli 		Details | Splinter Review
patch 5 (769 bytes, patch)
2010-10-28 07:23 UTC, Thomas Flüeli 		Details | Splinter Review
View All

Description Thomas Flüeli 2010-10-28 07:20:54 UTC 
I've made some changes to get gabble compile with MSVC 9.
Comment 1 Thomas Flüeli 2010-10-28 07:21:54 UTC 
Created attachment 39849 [details] [review]
patch 1
Comment 2 Thomas Flüeli 2010-10-28 07:22:22 UTC 
Created attachment 39850 [details] [review]
patch 2
Comment 3 Thomas Flüeli 2010-10-28 07:22:53 UTC 
Created attachment 39851 [details] [review]
patch 3
Comment 4 Thomas Flüeli 2010-10-28 07:23:13 UTC 
Created attachment 39852 [details] [review]
patch 4
Comment 5 Thomas Flüeli 2010-10-28 07:23:35 UTC 
Created attachment 39853 [details] [review]
patch 5
Comment 6 Simon McVittie 2010-10-28 08:21:19 UTC 
Review of attachment 39849 [details] [review]:

Does Windows really not have u_intNN_t? But, OK.
Comment 7 Simon McVittie 2010-10-28 08:22:20 UTC 
Review of attachment 39850 [details] [review]:

> cannot convert from 'GDebugKey' to 'GDebugKey'

Comedy. The cast is unnecessary, though, so we might as well remove it.
Comment 8 Simon McVittie 2010-10-28 08:22:47 UTC 
Review of attachment 39851 [details] [review]:

Sure, looks good.
Comment 9 Simon McVittie 2010-10-28 08:25:27 UTC 
Review of attachment 39852 [details] [review]:

I'm sure I already implemented this... oh, but that was in telepathy-glib, and Bug #26516 prevents using it. :-(

Your patch looks fine.
Comment 10 Simon McVittie 2010-10-28 08:25:51 UTC 
Review of attachment 39853 [details] [review]:

Looks good.
Comment 11 Simon McVittie 2010-10-28 08:26:23 UTC 
Review of attachment 39853 [details] [review]:

Looks good.
Comment 12 Simon McVittie 2010-10-28 08:52:32 UTC 
Thanks, I've merged all five patches in git (to the telepathy-gabble-0.10 and master branches).

Fixed in Gabble 0.10.4 and 0.11.0, when those versions are released.
Comment 13 Nicolas Dufresne 2010-10-28 11:06:30 UTC 
Review of attachment 39849 [details] [review]:

On windows they are called uint* (without underscore) for unknown reason, so it's better to use glib type indeed.
Comment 14 Simon McVittie 2010-10-28 11:20:12 UTC 
(In reply to comment #13)
> On windows they are called uint* (without underscore) for unknown reason, so
> it's better to use glib type indeed.

On closer inspection, uintNN_t is ISO, whereas u_intNN_t is non-standard (but is defined by sys/types.h on Linux, and for some reason gets syntax-highlit as a constant in vim, which uintNN_t does not).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.