Bug 31300

Created attachment 39964 [details] [review]
Add XF86XK_TouchpadOn/Off

Those keysyms will be used to report events from the hardware. Hardware
like the HP laptops emit 2 separate keycodes when the touchpad is enabled
or disabled. So we can catch those in user-space and display a popup.

Created attachment 39965 [details] [review]
kernel: Add touchpad on/off

For completeness sake (and so that it doesn't get lost), this is the kernel patch we'd use if X.org could handle > 255-8 keycodes.

Still TODO (for short-term):
- Fix udev to use F21, F22, F23 keys consistently (touchpad toggle, on, off for example)
- Fix evdev keymap to map linux' F2X keys to the newly added keysyms

> --- Comment #1 from Bastien Nocera <hadess@hadess.net> 2010-11-01 11:23:51 PDT ---
> Add XF86XK_TouchpadOn/Off
> 
Shouldn't that be XK_TouchpadOn/Off?  Or is there a reason to add it to
the XFree86 vendor-specific group?

The include is called XF86KeySym, and all the keys are XF86 prefixed. We should probably hide them in display though.

> --- Comment #4 from Bastien Nocera <hadess@hadess.net> 2010-11-01 14:01:59 PDT ---
> The include is called XF86KeySym, and all the keys are XF86 prefixed. We should
> probably hide them in display though.
> 
Not the ones in <X11/keysymdef.h>

(In reply to comment #5)
> > --- Comment #4 from Bastien Nocera <hadess@hadess.net> 2010-11-01 14:01:59 PDT ---
> > The include is called XF86KeySym, and all the keys are XF86 prefixed. We should
> > probably hide them in display though.
> > 
> Not the ones in <X11/keysymdef.h>

And I'm not adding anything there.

The ones in XF86KeySym.h are the addition past the original set of keys used by all vendors of X11 implementations.

FWIW, this isn't my first addition to the list of keysyms. See also https://bugs.freedesktop.org/show_bug.cgi?id=16519

> Shouldn't that be XK_TouchpadOn/Off?
> Or is there a reason to add it to the XFree86 vendor-specific group?

The consensus a while back was to leave the XF86 prefix to XFree86.

The only reason to add thses keys their, per that consensus, would be
if XFree86 first added them to their own dist.

Fixed in:
http://cgit.freedesktop.org/xorg/proto/x11proto/commit/?id=5d3428de974d15357b0ad407f4c5222cfaa8f9f3

commit 5d3428de974d15357b0ad407f4c5222cfaa8f9f3
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Nov 8 15:24:55 2010 +1000

    Add XF86XK_TouchpadOn/Off


Peter Hutterer:
"Tricky situation, mostly my fault. I added XF86XK_TouchpadToggle a year or
so ago to the XF86keysym database. That probably shouldn't have happened,
but given it's already in, adding those two here instead of keysymdef.h
seems to be the better thing to do."
http://lists.freedesktop.org/archives/xorg-devel/2010-November/015035.html