Bug 31998

Summary: relax assertions about how fast AddMembers/RemoveMembers succeed
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: gabbleAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: 0.11   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=shortlog;h=refs/heads/async-contact-list
Whiteboard: review+
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 31997    

Description Simon McVittie 2010-11-30 05:21:47 UTC
+++ This bug was initially created as a clone of Bug #31997 +++

> To port Haze to TpBaseContactList [...] There are two ways we could fix this:
> * Override AddMembers, RemoveMembers and RemoveMembersWithReason in
>   the internal ContactList channels; make them succeed/fail
>   asynchronously. This breaks the Gabble tests, which expect these
>   methods to succeed immediately unless there's an obvious problem like
>   a bad handle.

If we go that way, we'll need this Gabble patch.
Comment 1 Jonny Lamb 2010-11-30 09:08:21 UTC
This looks fine. I especially enjoy how your FIXME comments describing what to do when gabble depends on a new enough tp-glib are all different.
Comment 2 Simon McVittie 2010-11-30 09:17:59 UTC
Fixed in git for 0.11.3

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.