|Summary:||relax assertions about how fast AddMembers/RemoveMembers succeed|
|Product:||Telepathy||Reporter:||Simon McVittie <smcv>|
|Component:||gabble||Assignee:||Simon McVittie <smcv>|
|Status:||RESOLVED FIXED||QA Contact:||Telepathy bugs list <telepathy-bugs>|
|i915 platform:||i915 features:|
|Bug Depends on:|
Description Simon McVittie 2010-11-30 05:21:47 UTC
+++ This bug was initially created as a clone of Bug #31997 +++ > To port Haze to TpBaseContactList [...] There are two ways we could fix this: > > * Override AddMembers, RemoveMembers and RemoveMembersWithReason in > the internal ContactList channels; make them succeed/fail > asynchronously. This breaks the Gabble tests, which expect these > methods to succeed immediately unless there's an obvious problem like > a bad handle. If we go that way, we'll need this Gabble patch.
Comment 1 Jonny Lamb 2010-11-30 09:08:21 UTC
This looks fine. I especially enjoy how your FIXME comments describing what to do when gabble depends on a new enough tp-glib are all different.
Comment 2 Simon McVittie 2010-11-30 09:17:59 UTC
Fixed in git for 0.11.3