Bug 31998 - relax assertions about how fast AddMembers/RemoveMembers succeed
Summary: relax assertions about how fast AddMembers/RemoveMembers succeed
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: 0.11
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks: 31997
  Show dependency treegraph
Reported: 2010-11-30 05:21 UTC by Simon McVittie
Modified: 2010-11-30 09:17 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description Simon McVittie 2010-11-30 05:21:47 UTC
+++ This bug was initially created as a clone of Bug #31997 +++

> To port Haze to TpBaseContactList [...] There are two ways we could fix this:
> * Override AddMembers, RemoveMembers and RemoveMembersWithReason in
>   the internal ContactList channels; make them succeed/fail
>   asynchronously. This breaks the Gabble tests, which expect these
>   methods to succeed immediately unless there's an obvious problem like
>   a bad handle.

If we go that way, we'll need this Gabble patch.
Comment 1 Jonny Lamb 2010-11-30 09:08:21 UTC
This looks fine. I especially enjoy how your FIXME comments describing what to do when gabble depends on a new enough tp-glib are all different.
Comment 2 Simon McVittie 2010-11-30 09:17:59 UTC
Fixed in git for 0.11.3

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.