Bug 32299

Summary: allow out-of-tree builds, perhaps by using Autoconf
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: tp-specAssignee: Simon McVittie <smcv>
Status: RESOLVED MOVED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: enhancement    
Priority: medium Keywords: patch
Version: git master   
Hardware: Other   
OS: All   
URL: http://cgit.freedesktop.org/~smcv/telepathy-spec/log/?h=autotools
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 31505    

Description Simon McVittie 2010-12-10 10:47:15 UTC
telepathy-spec can't be submoduled into autotools projects easily, because it doesn't itself use autotools, so you can't `make dist` from an out-of-tree build.

One possible way to fix this is to make it into a really simple autotools project.

Crack or not?
Comment 1 Simon McVittie 2011-06-06 11:16:12 UTC
Repo moved, URL will be available when cron picks it up. It's the autotools branch of: ssh://people.freedesktop.org/~smcv/telepathy-spec.git
Comment 2 David Laban 2011-06-08 14:36:55 UTC
http://cgit.freedesktop.org/~smcv/telepathy-spec/commit/?h=autotools&id=441717252d3704895068ddc14b2b9423cbe7255d

Can you remind me of the difference between srcdir and top_srcdir?

I'm not sure how I feel about adding autotools to spec, unless I can see it in action. 

If we decide to go down the telepathy-core repo path, I will probably just merge this into that repo, so there's no point in merging it to telepathy-spec master.

If we don't decide to have a telepathy-core repo, I'm slightly scared of driving autotools from CMake. Do you have an example of tp-glib or tp-qt4 using it as a submodule, or should I just try it out myself and come running to you with the pieces if/when I break it?
Comment 3 Simon McVittie 2011-06-09 02:37:32 UTC
(In reply to comment #2)
> Can you remind me of the difference between srcdir and top_srcdir?

No difference in this particular project, because it only has one Makefile.am.

top_srcdir is always the (possibly relative) path to the directory containing our configure.ac. (If you're in a nested project with its own configure.ac, like Wocky inside Gabble, then the top_srcdir is the dir containing Wocky's configure.ac, not Gabble's configure.ac.)

srcdir is the (possibly relative) path to the source subdirectory that corresponds to the build subdirectory you're in right now (so in an in-tree build it's always ".").

> If we decide to go down the telepathy-core repo path, I will probably just
> merge this into that repo, so there's no point in merging it to telepathy-spec
> master.

That sounds like a good approach; copying my code will hopefully save you a bit of time, at least.

> If we don't decide to have a telepathy-core repo, I'm slightly scared of
> driving autotools from CMake. Do you have an example of tp-glib or tp-qt4 using
> it as a submodule, or should I just try it out myself and come running to you
> with the pieces if/when I break it?

I certainly had it working in telepathy-glib once, but I've probably lost the branch.

I don't know how it'd hook into CMake: worst case, we keep using the "copy the XML" approach for tp-qt4, or submodule it in but then omit it from the CMake equivalent of SUBDIRS and dist the necessary files by hand (much like we have to do now anyway).
Comment 4 Simon McVittie 2012-01-30 08:23:39 UTC
I've updated the branch for current spec.
Comment 5 GitLab Migration User 2019-12-03 20:23:26 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-spec/issues/100.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.