| Summary: | ContactsChanged doesn't carry IDs | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | tp-spec | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | andrunko, olli.salli, will |
| Version: | git master | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/wjt/telepathy-spec-wjt.git;a=shortlog;h=refs/heads/contact-ids | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Both patches seems fine to me. Just one thing, wouldn't it be good to add that ContactsChanged is now deprecated and new code should implement ContactsChangedWithId? Spec branch updated. bzzt. The docstrings for the old signal—ContactsChanged—define their arguments with "+ The same as the corresponding argument to ContactsChanged." I'll fix this up. The top two commits on my branch fix this and add some miscellaneous markup. r+ on IRC from Sjoerd; will be in 0.21.8. (oh and I'll put the tp-glib bit into a release once that's out.) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
09:58 < andrunko> 19:56:23> oggis_, I want to discuss with simon the fact that I can't construct the contacts synchronously using the new ContactList API when new contacts are added with ContactList.ContactsChanged as I don't receive the id there, and if there is a reason behind it ... 09:58 < wjt> 19:59:49> well, damn 09:58 < wjt> 20:00:03> looks like we need ContactsChanged2 which includes their id ... 09:58 < oggis_> 20:00:46> as andre points out, with handles immutable everywhere, it WOULD actually help 09:58 < oggis_> 20:00:49> (unlike currently) (If you want to discuss things with me on IRC, highlighting me might help :-) Spec patch to add ContactsChangedWithIDs: http://git.collabora.co.uk/?p=user/smcv/telepathy-spec-smcv.git;a=shortlog;h=refs/heads/contact-ids Proof-of-concept implementation in TpBaseContactList, in which the actual signal is #if 0 until we get the spec landed: http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/better-contact-list