Bug 32467 - ContactsChanged doesn't carry IDs
Summary: ContactsChanged doesn't carry IDs
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-spec (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-12-17 02:59 UTC by Simon McVittie
Modified: 2010-12-20 08:35 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Simon McVittie 2010-12-17 02:59:19 UTC 
09:58 < andrunko> 19:56:23> oggis_, I want to discuss with simon the fact that 
                  I can't construct the contacts synchronously using the new 
                  ContactList API when new contacts are added with 
                  ContactList.ContactsChanged as I don't receive the id there, 
                  and if there is a reason behind it
...
09:58 < wjt> 19:59:49> well, damn
09:58 < wjt> 20:00:03> looks like we need ContactsChanged2 which includes their 
             id
...
09:58 < oggis_> 20:00:46> as andre points out, with handles immutable 
                everywhere, it WOULD actually help
09:58 < oggis_> 20:00:49> (unlike currently)


(If you want to discuss things with me on IRC, highlighting me might help :-)

Spec patch to add ContactsChangedWithIDs:

http://git.collabora.co.uk/?p=user/smcv/telepathy-spec-smcv.git;a=shortlog;h=refs/heads/contact-ids

Proof-of-concept implementation in TpBaseContactList, in which the actual signal is #if 0 until we get the spec landed:

http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/better-contact-list
Comment 1 Andre Moreira Magalhaes 2010-12-17 03:57:54 UTC 
Both patches seems fine to me. Just one thing, wouldn't it be good to add that ContactsChanged is now deprecated and new code should implement ContactsChangedWithId?
Comment 2 Simon McVittie 2010-12-17 04:05:32 UTC 
Spec branch updated.
Comment 3 Will Thompson 2010-12-20 07:26:35 UTC 
bzzt. The docstrings for the old signal—ContactsChanged—define their arguments with "+          The same as the corresponding argument to ContactsChanged."

I'll fix this up.
Comment 4 Will Thompson 2010-12-20 08:05:58 UTC 
The top two commits on my branch fix this and add some miscellaneous markup.
Comment 5 Will Thompson 2010-12-20 08:35:33 UTC 
r+ on IRC from Sjoerd; will be in 0.21.8.
Comment 6 Will Thompson 2010-12-20 08:35:50 UTC 
(oh and I'll put the tp-glib bit into a release once that's out.)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.