| Summary: | [SNB] case ogles2conform/GL/gl_FragCoord/gl_FragCoord_xy_frag.test and gl_FragCoord_w_frag.test fail | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Yi Sun <yi.sun> |
| Component: | Drivers/DRI/i965 | Assignee: | Kenneth Graunke <kenneth> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | haihao.xiang, idr, nanhai.zou, yuanhan.liu, zhenyu.z.wang |
| Version: | 7.10 | ||
| Hardware: | Other | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Yi Sun
2011-01-25 23:24:23 UTC
Both two cases are passed on IronLake platform. I have a fix for this in my 'snb-fixes' branch. I hope to push it on Tuesday (after the holiday). Fixed in latest Mesa master. commit 4a3b28113c3d23ba21bb8b8f5ebab7c567083a6d Author: Kenneth Graunke <kenneth@whitecape.org> Date: Sat Feb 19 16:48:24 2011 -0800 i965/fs: Correctly set up gl_FragCoord.w on Sandybridge. pixel_w is the final result; wpos_w is used on gen4 to compute it. NOTE: This is a candidate for the 7.10 branch. Reviewed-by: Eric Anholt <eric@anholt.net> commit 3e91070ea81da970b640acf22e2b1aa761161906 Author: Kenneth Graunke <kenneth@whitecape.org> Date: Tue Feb 22 10:04:18 2011 -0800 i965: Fix shaders that write to gl_PointSize on Sandybridge. gl_PointSize (VERT_RESULT_PSIZ) doesn't take up a message register, as it's part of the header. Without this fix, writing to gl_PointSize would cause the SF to read and use the wrong attributes, leading to all kinds of random looking failure. Reviewed-by: Eric Anholt <eric@anholt.net> I have retested the Ogles2conform cases "GL_gl_FragCoord_gl_FragCoord_xy_frag.test" and "GL_gl_FragCoord_gl_FragCoord_w_frag.test", they can pass in latest Mesa master. Mesa:commit 6d1f28d6c045f768da2eee779006535acf382cce leave open until cherry-picked to 7.10. Ken/Ian, have the patches cherry-picked, so we can close this? This one should stay open; I just reverted the patch to "fix" gl_FragCoord.w on Sandybridge since it regressed Ironlake (bug #34646...I could've sworn I tested that...) unblocking Q1 release. Should be fixed on Mesa master: commit 5d7fefb9afbcc6f1d58a92d07c390e6b912c3b00 Author: Kenneth Graunke <kenneth@whitecape.org> Date: Sun Apr 3 01:39:28 2011 -0700 i965/fs: Switch W and 1/W in Sandybridge interpolation setup. Various documentation mentions that "W" is handed to the WM stage, but further digging seems to indicate that they really mean 1/W. The code here is still unclear, but changing this fixes piglit test "fragcoord_w" on Sandybridge as well as a Khronos ES2 conformance test. I also tested 3DMarkMobile ES2.0's taiji and hoverjet demos, as well as Nexuiz, just to be safe. NOTE: This is a candidate for the 7.10 branch. Cherry-picked to 7.10 branch. Passed on commit mesa (7.10)fc23cc06af90b5945de2c1f5e045b2b93f5ee70b So verified it. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.