Bug 33651

Summary:	Possible leak in recover_connection in McdAccountManager
Product:	Telepathy	Reporter:	Marco Barisione <marco.barisione>
Component:	mission-control	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	vivek
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/bari/telepathy-mission-control.git;a=shortlog;h=refs/heads/return-if-fail-leak
Whiteboard:	review+
i915 platform:		i915 features:

Description Marco Barisione 2011-01-28 07:01:54 UTC

recover_connections has a g_return_val_if_fail() in the middle of the functions. In case mcd_master_get_default() there will be an early return leading to a memory leak.

Comment 1 Marco Barisione 2011-01-28 07:16:47 UTC

Vivek, can you please review?

Comment 2 Vivek Dasmohapatra 2011-01-28 07:37:56 UTC

looks good.

Comment 3 Marco Barisione 2011-01-28 08:16:56 UTC

Committed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.