Bug 33651 - Possible leak in recover_connection in McdAccountManager
Summary: Possible leak in recover_connection in McdAccountManager
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/ba...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-01-28 07:01 UTC by Marco Barisione
Modified: 2011-01-28 08:16 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Marco Barisione 2011-01-28 07:01:54 UTC 
recover_connections has a g_return_val_if_fail() in the middle of the functions. In case mcd_master_get_default() there will be an early return leading to a memory leak.
Comment 1 Marco Barisione 2011-01-28 07:16:47 UTC 
Vivek, can you please review?
Comment 2 Vivek Dasmohapatra 2011-01-28 07:37:56 UTC 
looks good.
Comment 3 Marco Barisione 2011-01-28 08:16:56 UTC 
Committed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.