| Summary: | Implement FileTransfer.FileURI | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Guillaume Desmottes <guillaume.desmottes> |
| Component: | salut | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | enhancement | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/cassidy/telepathy-salut;a=shortlog;h=refs/heads/file-uri-33833 | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
|
Description
Guillaume Desmottes
2011-02-02 04:08:50 UTC
http://git.collabora.co.uk/?p=user/cassidy/telepathy-salut;a=shortlog;h=refs/heads/file-uri-33833 That's basically the same implementation as in Gabble. + /* ContentHashType has to be first so we can easily skip it when needed */ Is this true in Salut? In salut_file_transfer_channel_get_property: + self->priv->uri != NULL ? self->priv->uri: ""); you are missing a space here: ^^ Otherwise looks reasonable. I assume you did the constants change with Sed or something, so I didn't read every line of the diff. :) (In reply to comment #2) > + /* ContentHashType has to be first so we can easily skip it when needed */ > > Is this true in Salut? Oh good catch, it's not. I'm still thinking it's worth keeping Salut and Gabble's code as close as possible, so I kept the ordering but updated the comment. > In salut_file_transfer_channel_get_property: > > + self->priv->uri != NULL ? self->priv->uri: ""); > > you are missing a space here: ^^ fixed. Merged to master; will be in 0.5.0 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.