Bug 33833 - Implement FileTransfer.FileURI
Summary: Implement FileTransfer.FileURI
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: salut (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/ca...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-02-02 04:08 UTC by Guillaume Desmottes
Modified: 2011-02-03 05:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Guillaume Desmottes 2011-02-02 04:08:50 UTC
Salut should implement the FileTransfer.FileURI property.
Comment 1 Guillaume Desmottes 2011-02-02 08:16:38 UTC
http://git.collabora.co.uk/?p=user/cassidy/telepathy-salut;a=shortlog;h=refs/heads/file-uri-33833

That's basically the same implementation as in Gabble.
Comment 2 Will Thompson 2011-02-02 09:37:52 UTC
+  /* ContentHashType has to be first so we can easily skip it when needed */

Is this true in Salut?

In salut_file_transfer_channel_get_property:

+            self->priv->uri != NULL ? self->priv->uri: "");

you are missing a space here:                        ^^

Otherwise looks reasonable. I assume you did the constants change with Sed or something, so I didn't read every line of the diff. :)
Comment 3 Guillaume Desmottes 2011-02-03 00:59:57 UTC
(In reply to comment #2)
> +  /* ContentHashType has to be first so we can easily skip it when needed */
> 
> Is this true in Salut?

Oh good catch, it's not. I'm still thinking it's worth keeping Salut and
Gabble's code as close as possible, so I kept the ordering but updated the
comment.

> In salut_file_transfer_channel_get_property:
> 
> +            self->priv->uri != NULL ? self->priv->uri: "");
> 
> you are missing a space here:                        ^^

fixed.
Comment 4 Guillaume Desmottes 2011-02-03 05:58:19 UTC
Merged to master; will be in 0.5.0


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.