Summary: | Don't call ObserverChannels with unapproved channels on recovering Observer | ||
---|---|---|---|
Product: | Telepathy | Reporter: | Guillaume Desmottes <guillaume.desmottes> |
Component: | mission-control | Assignee: | Simon McVittie <smcv> |
Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
Severity: | normal | ||
Priority: | medium | CC: | vivek |
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
URL: | http://cgit.collabora.com/git/user/smcv/telepathy-mission-control-smcv.git/log/?h=58-recovery-position | ||
Whiteboard: | r+ | ||
i915 platform: | i915 features: | ||
Attachments: |
channel was approved
channel was not yet approved [PATCH 1/3] fd.o #34025: call ObserveChannels for channels waiting in CDOs when recovering [PATCH 2/3] Regression test for passing unapproved channels to recovering observers [PATCH 3/3] update autogenerated gtk-doc goo |
Description
Guillaume Desmottes
2011-02-08 02:29:21 UTC
Created attachment 43089 [details]
channel was approved
Created attachment 43090 [details]
channel was not yet approved
On my list. Will get to it as soon as I can, probably tomorrow, certainly this week. I looked at this briefly and spotted the failure mode; patches on the way. Created attachment 46899 [details] [review] [PATCH 1/3] fd.o #34025: call ObserveChannels for channels waiting in CDOs when recovering Created attachment 46900 [details] [review] [PATCH 2/3] Regression test for passing unapproved channels to recovering observers I've confirmed that this fails without patch 1/3. Created attachment 46901 [details] [review] [PATCH 3/3] update autogenerated gtk-doc goo Not really related to this bug, but it's been annoying me every time I rebuild MC... Looks good Thanks, fixed in git for 5.8.0, 5.9.1. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.