Bug 34025 - Don't call ObserverChannels with unapproved channels on recovering Observer
Summary: Don't call ObserverChannels with unapproved channels on recovering Observer
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/sm...
Whiteboard: r+
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-08 02:29 UTC by Guillaume Desmottes
Modified: 2011-05-19 08:45 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
channel was approved (10.94 KB, text/plain)
2011-02-08 02:29 UTC, Guillaume Desmottes 		Details
channel was not yet approved (10.77 KB, text/plain)
2011-02-08 02:30 UTC, Guillaume Desmottes 		Details
[PATCH 1/3] fd.o #34025: call ObserveChannels for channels waiting in CDOs when recovering (3.32 KB, patch)
2011-05-19 05:45 UTC, Simon McVittie 		Details | Splinter Review
[PATCH 2/3] Regression test for passing unapproved channels to recovering observers (6.54 KB, patch)
2011-05-19 05:46 UTC, Simon McVittie 		Details | Splinter Review
[PATCH 3/3] update autogenerated gtk-doc goo (2.07 KB, patch)
2011-05-19 05:46 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Guillaume Desmottes 2011-02-08 02:29:21 UTC 
MC doesn't call ObserveChannels() on an Observer having Recover if the channel has not be approved yet. See these 2 MC logs when restarting gnome-shell.
Comment 1 Guillaume Desmottes 2011-02-08 02:29:53 UTC 
Created attachment 43089 [details]
channel was approved
Comment 2 Guillaume Desmottes 2011-02-08 02:30:12 UTC 
Created attachment 43090 [details]
channel was not yet approved
Comment 3 Vivek Dasmohapatra 2011-02-08 04:20:49 UTC 
On my list. Will get to it as soon as I can, probably tomorrow, certainly this week.
Comment 4 Simon McVittie 2011-05-19 05:44:59 UTC 
I looked at this briefly and spotted the failure mode; patches on the way.
Comment 5 Simon McVittie 2011-05-19 05:45:44 UTC 
Created attachment 46899 [details] [review]
[PATCH 1/3] fd.o #34025: call ObserveChannels for channels waiting  in CDOs when recovering
Comment 6 Simon McVittie 2011-05-19 05:46:10 UTC 
Created attachment 46900 [details] [review]
[PATCH 2/3] Regression test for passing unapproved channels to  recovering observers

I've confirmed that this fails without patch 1/3.
Comment 7 Simon McVittie 2011-05-19 05:46:44 UTC 
Created attachment 46901 [details] [review]
[PATCH 3/3] update autogenerated gtk-doc goo

Not really related to this bug, but it's been annoying me every time I rebuild MC...
Comment 8 Guillaume Desmottes 2011-05-19 08:19:30 UTC 
Looks good
Comment 9 Simon McVittie 2011-05-19 08:45:15 UTC 
Thanks, fixed in git for 5.8.0, 5.9.1.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.