Bug 34251

Summary:	Cleanup of unused code and comments
Product:	Telepathy	Reporter:	Stef Walter <stefw>
Component:	salut	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:	review+
i915 platform:		i915 features:
Attachments:	Remove unused member variable. Cleanup comments that no longer match source.

Description Stef Walter 2011-02-14 02:23:27 UTC

Some cleanup patches for unused code and comments.


 * Cleanup some comments that no longer match source.
 * Remove unused member variable: SalutImManagerPrivate::pending_connections

Comment 1 Stef Walter 2011-02-14 02:24:15 UTC

Created attachment 43337 [details] [review]
Remove unused member variable.

Comment 2 Stef Walter 2011-02-14 02:24:48 UTC

Created attachment 43338 [details] [review]
Cleanup comments that no longer match source.

Comment 3 Jonny Lamb 2011-02-14 03:04:39 UTC

Looks good.

Comment 4 Stef Walter 2011-02-14 03:07:31 UTC

Here's a branch with these patches:

http://git.collabora.co.uk/?p=user/stefw/telepathy-salut.git;a=shortlog;h=refs/heads/salut-nitpicks

Comment 5 Stef Walter 2011-02-14 03:26:34 UTC

Merged with master.

Comment 6 Stef Walter 2011-02-15 23:52:50 UTC

I didn't notice that the push failed. I need to get in a few more patches before I get repository access. Anyone want to merge and push this for me?

Comment 7 Jonny Lamb 2011-02-16 00:32:37 UTC

Agh, no you asked me to merge this for you which I completely forgot to do! I just merged it now! Sorry for this!

Comment 8 Stef Walter 2011-02-16 01:13:52 UTC

No worries. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.