| Summary: | tp-glib doesn't compile under gcc 4.6 | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Dan Winship <danw> |
| Component: | tp-glib | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/wjt/telepathy-glib.git;a=shortlog;h=refs/heads/fd.o-34337-gcc-4.6 are | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
patch for "variable is set but not used"
patch for "condition is always true" |
||
|
Description
Dan Winship
2011-02-16 06:29:35 UTC
Created attachment 43427 [details] [review] patch for "variable is set but not used" Created attachment 43428 [details] [review] patch for "condition is always true" (In reply to comment #0) > I would write stuff here, but I'm annoyed about the lack of a --disable-werror > flag, so I'd just end up flaming. FYI it's called --disable-Werror here; numbered releases turn off -Werror by default, so it's normally only active for builds from git. yeah, wjt pointed it out on irc; I was looking for it in configure.ac, figuring you'd just not pass the "werror-by-default" flag to TP_COMPILER_WARNINGS in that case... Review of attachment 43427 [details] [review]: Thanks very much! (I had thought I'd fixed many of these a few weeks when experimenting with clang, but discovered that I'd just stashed the changes…) Review of attachment 43428 [details] [review]: I'm instead going to fix the macros to remove this check. I've checked, and nothing that uses them ever passes NULL… Review of attachment 43428 [details] [review]: I'm instead going to fix the macros to remove this check. I've checked, and nothing that uses them ever passes NULL… here's a fix for the tp_clear_* macros, and some more fixes for warnings produced by clang. Fixed in master (at last, sorry for the delay). Thanks for the report and patches! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.