Bug 34337 - tp-glib doesn't compile under gcc 4.6
Summary: tp-glib doesn't compile under gcc 4.6
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-02-16 06:29 UTC by Dan Winship
Modified: 2011-03-15 11:13 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch for "variable is set but not used" (7.13 KB, patch)
2011-02-16 06:29 UTC, Dan Winship 		Details | Splinter Review
patch for "condition is always true" (5.15 KB, patch)
2011-02-16 06:30 UTC, Dan Winship 		Details | Splinter Review
View All

Description Dan Winship 2011-02-16 06:29:35 UTC 
I would write stuff here, but I'm annoyed about the lack of a --disable-werror flag, so I'd just end up flaming.
Comment 1 Dan Winship 2011-02-16 06:29:57 UTC 
Created attachment 43427 [details] [review]
patch for "variable is set but not used"
Comment 2 Dan Winship 2011-02-16 06:30:18 UTC 
Created attachment 43428 [details] [review]
patch for "condition is always true"
Comment 3 Simon McVittie 2011-02-16 06:35:20 UTC 
(In reply to comment #0)
> I would write stuff here, but I'm annoyed about the lack of a --disable-werror
> flag, so I'd just end up flaming.

FYI it's called --disable-Werror here; numbered releases turn off -Werror by default, so it's normally only active for builds from git.
Comment 4 Dan Winship 2011-02-16 07:23:03 UTC 
yeah, wjt pointed it out on irc; I was looking for it in configure.ac, figuring you'd just not pass the "werror-by-default" flag to TP_COMPILER_WARNINGS in that case...
Comment 5 Will Thompson 2011-02-24 04:08:26 UTC 
Review of attachment 43427 [details] [review]:

Thanks very much! (I had thought I'd fixed many of these a few weeks when experimenting with clang, but discovered that I'd just stashed the changes…)
Comment 6 Will Thompson 2011-02-24 04:13:37 UTC 
Review of attachment 43428 [details] [review]:

I'm instead going to fix the macros to remove this check. I've checked, and nothing that uses them ever passes NULL…
Comment 7 Will Thompson 2011-02-24 04:13:39 UTC 
Review of attachment 43428 [details] [review]:

I'm instead going to fix the macros to remove this check. I've checked, and nothing that uses them ever passes NULL…
Comment 8 Will Thompson 2011-02-24 09:31:15 UTC 
here's a fix for the tp_clear_* macros, and some more fixes for warnings produced by clang.
Comment 9 Will Thompson 2011-03-15 11:13:46 UTC 
Fixed in master (at last, sorry for the delay). Thanks for the report and patches!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.