| Summary: | Add API for DelegateChannels() and PresentChannel() | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Guillaume Desmottes <guillaume.desmottes> |
| Component: | tp-glib | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | enhancement | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.collabora.co.uk/git/user/cassidy/telepathy-glib/log/?h=re-dispatch-34610 | ||
| Whiteboard: | review le plus | ||
| i915 platform: | i915 features: | ||
| Bug Depends on: | 25293, 37109 | ||
| Bug Blocks: | |||
|
Description
Guillaume Desmottes
2011-02-23 05:56:24 UTC
+ chans = g_ptr_array_sized_new (g_list_length (channels)); + g_ptr_array_set_free_func (chans, g_free); + + for (l = channels; l != NULL; l = g_list_next (l)) ... makes me a little unhappy but I'm not sure what to do. Why don't you make _delegate_channels_async take a GPtrArray instead of a GList? I'm not sure what your PresentChannel test actually tests, but whatever. Looks good otherwise. (In reply to comment #2) > + chans = g_ptr_array_sized_new (g_list_length (channels)); > + g_ptr_array_set_free_func (chans, g_free); > + > + for (l = channels; l != NULL; l = g_list_next (l)) > ... > > makes me a little unhappy but I'm not sure what to do. > > Why don't you make _delegate_channels_async take a GPtrArray instead of a > GList? Because we usually use GList in high level API (see for example TpBaseClientClassObserveChannelsImpl and friends). But I'm ready to be convinced otherwise. > I'm not sure what your PresentChannel test actually tests, but whatever. Not much, but at least his code is run in a test (and it did help me to find a bug: I was passing the wrong source_tag when checking in _finish). Okay fine, gogogogogo once your MC branch is merged. http://cgit.collabora.co.uk/git/user/cassidy/telepathy-glib/log/?h=re-dispatch-34610 now implements the new spec (bug #37109) (In reply to comment #5) > http://cgit.collabora.co.uk/git/user/cassidy/telepathy-glib/log/?h=re-dispatch-34610 > now implements the new spec (bug #37109) + * @not_delegated: (out) (element-type TelepathyGLib.Channel GLib.Error) (transfer container): hero! + * can be used to known the channels that @self is not handling any more, *know + * if not %NULL, used to return a #GPtrArray containing the #TpChannel which #TpChannel<!-- -->s (lol) + * fnot not %NULL, used to return a #GHashTable mapping #TpChannel which have *if not %NULL OTHERWISE FINE GOGOGOGOGOGOGO OGMASOEFMAOEFIJAWEUOHAUEIFNHCAOIENAWOIEJWEOFJAOIEJFOIAWEJFOIAEJOIAEJFIOA OMG IT'S THE WEEKEND SO EXCITED WAHIOEHAOIEHNOAIENOAWE (In reply to comment #6) > + * @not_delegated: (out) (element-type TelepathyGLib.Channel GLib.Error) > (transfer container): > > hero! Fear my GIR sK1llz! > + * can be used to known the channels that @self is not handling any more, > > *know fixed. > + * if not %NULL, used to return a #GPtrArray containing the #TpChannel which > > #TpChannel<!-- -->s (lol) fixed. > + * fnot not %NULL, used to return a #GHashTable mapping #TpChannel which have > > *if not %NULL fixed. > OTHERWISE FINE GOGOGOGOGOGOGO > OGMASOEFMAOEFIJAWEUOHAUEIFNHCAOIENAWOIEJWEOFJAOIEJFOIAWEJFOIAEJOIAEJFIOA > > OMG IT'S THE WEEKEND SO EXCITED WAHIOEHAOIEHNOAIENOAWE Bouh, Monday already. :( Gogogo Merged to master, will be in 0.15.1. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.