As discussed on IRC, DelegateChannels() should return the list of channels which have been delegated and those which have not.
http://cgit.collabora.co.uk/git/user/cassidy/telepathy-spec/log/?h=delegate-channels-37109 http://people.freedesktop.org/~gdesmott/telepathy-spec-delegate_channels_37109/spec/Channel_Dispatcher.html#Method:DelegateChannels
Not sure about some of the indentation around this change, but meh. + <p>This method returns once all the <var>Channels</var> have either be + accepted or rejected by Handlers.</p> ...have either been accepted... + <p>Client SHOULD remove those channels from their The client should remove these channels from its + <tp:dbus-ref namespace="org.freedesktop.Telepathy.Client.Handler">HandledChannels</tp:dbus-ref> use "ofdT" instead of "org.freedesktop.Telepathy" You should add a tp:changed or whatever it is saying what version it changed in and what exactly changed.
(In reply to comment #2) > + <p>This method returns once all the <var>Channels</var> have either be > + accepted or rejected by Handlers.</p> > > ...have either been accepted... fixed. > + <p>Client SHOULD remove those channels from their > > The client should remove these channels from its changed. > + <tp:dbus-ref > namespace="org.freedesktop.Telepathy.Client.Handler">HandledChannels</tp:dbus-ref> > > use "ofdT" instead of "org.freedesktop.Telepathy" done. > You should add a tp:changed or whatever it is saying what version it changed in > and what exactly changed. I updated the branch and HTML.
Created attachment 46665 [details] [review] DelegateChannels: return the list channels of (not) delegated channels (fdo #37109)
You need to change the tp:docstring for InvalidArgument for DelegateChannels as it no longer has an Account argument. + <tp:changed version="0.23.UNRELEASED">This methods now returns *method in the NotYours error tp:docstring: "The caller is not currently handling the channels. " Can you clarify this please? Will it fail with NotYours if only one of the channels is not being handled by this handler? What will happen to the other channels? Sorry I should have noticed those before.
(In reply to comment #5) > You need to change the tp:docstring for InvalidArgument for DelegateChannels as > it no longer has an Account argument. removed. > + <tp:changed version="0.23.UNRELEASED">This methods now returns > > *method fixed. > in the NotYours error tp:docstring: > > "The caller is not currently handling the channels. " > > Can you clarify this please? Will it fail with NotYours if only one of the > channels is not being handled by this handler? What will happen to the other > channels? done.
Looks good.
Merged to master; will be in 0.23.2.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.