Bug 34709

Can you bisect?

Maybe you did not notice but I was asking what repo would be suitable for bisecting this.

I know there are several drm repos but I have no clue what is in what.

Linus' tree is fine:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git

Can't reproduce on my other box so I will need to do some parts swapping I guess.

hmm, so it does not happen on rv515gl
hopefully can bisect with the rv530

It breaks two commits after 2.6.37-rc3.

Luckily it's in the rc range where the kernels build and boot, bisecting something before rc with Linus tree is hell.

The first cut which was halfway between 2.6.36 and 2.6.37 would not boot and had some oops in atl1 which I happen to use to connect to the box.

commit f24d86f1a49505cdea56728b853a5d0a3f8e3d11
Author: Alex Deucher <alexdeucher@gmail.com>
Date:   Fri Nov 19 23:27:04 2010 +0000

    drm/radeon/kms: fix resume regression for some r5xx laptops

(In reply to comment #6)
> commit f24d86f1a49505cdea56728b853a5d0a3f8e3d11
> Author: Alex Deucher <alexdeucher@gmail.com>
> Date:   Fri Nov 19 23:27:04 2010 +0000
> 
>     drm/radeon/kms: fix resume regression for some r5xx laptops

Are you saying that with this commit reverted it works?

I did not try to revert it. It's way old. Just tried the kernel before and after.

Note that this is very hardware specific, I get the issue with rv530 but not rv515gl.

(In reply to comment #8)
> I did not try to revert it. It's way old. Just tried the kernel before and
> after.
> 
> Note that this is very hardware specific, I get the issue with rv530 but not
> rv515gl.

So the commit before it worked and the one after it did not?

Yes, it does not work with this commit.

I tried to patch a revert on top of 2.6.37 and the kernel suspends fine then.

commit 0c6a5be872fc2c2dc1774501429349ba03d8b2a6
Author: Michal Suchanek <hramrach@centrum.cz>
Date:   Fri Apr 1 23:24:17 2011 +0200

    Revert "drm/radeon/kms: fix resume regression for some r5xx laptops"
    
    This reverts commit f24d86f1a49505cdea56728b853a5d0a3f8e3d11.

commit 3c0eee3fe6a3a1c745379547c7e7c904aa64f6d5
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Tue Jan 4 16:50:19 2011 -0800

    Linux 2.6.37

Created attachment 45164 [details] [review]
fix

This patch should fix it.

With the patch 2.6.37 suspends and resumes, 2.6.38 suspends (which was not possible without it ) and locks up on resume.

On rv515gl 2.6.38 suspends and resumes fine without patches.

(In reply to comment #12)
> With the patch 2.6.37 suspends and resumes, 2.6.38 suspends (which was not
> possible without it ) and locks up on resume.

Can you bisect (and apply the patch from comment 11 as needed) to track down what broken resume?

ok, with the patch 2.6.37 works, 2.6.38 and head suspends but lockups on resume.

I guess time for another bisect.

Is the fix going to be applied?

Any luck bisecting the resume issues?

Those are not caused by Radeon.

They were only hidden by the Radeon issue because it came earlier.

(In reply to comment #17)
> Those are not caused by Radeon.
> 
> They were only hidden by the Radeon issue because it came earlier.

So the patch alone fixes suspend and resume?

The resume issue should be fixed in 2.6.39-rc3.

commit 4da9484bdece39ab0b098fa711e095e3e9fc8684
Author: H. Peter Anvin <hpa@linux.intel.com>
Date:   Wed Apr 6 13:10:02 2011 -0700

    x86, hibernate: Initialize mmu_cr4_features during boot
    
    Restore the initialization of mmu_cr4_features during boot, which was
    removed without comment in checkin e5f15b45ddf3afa2bbbb10c7ea34fb32b6de0a0e
    
    x86: Cleanup highmap after brk is concluded
    
    thereby breaking resume from hibernate.  This restores previous
    functionality in approximately the same place, and corrects the

I've sent the patch to Dave.

Fixed in 2.6.38.4.