After upgrading from kernel 2.6.36 to 2.6.37 I can no longer suspend the system with uswsusp.
The suspend operation hangs with displays blanked before the part when "Saving image to disk" takes place.
Suspending with "echo disk > /sys/power/state" works but is obviously useless as the system cannot be resumed.
Upgrading to 2.6.38 does not help, not loading the radeon module allows to suspend as usual.
A pointer to a repo with Radeon changesets between 2.6.36 and 2.6.37 without needlessly intermingled changes to other kernel parts would be appreciated.
Can you bisect?
Maybe you did not notice but I was asking what repo would be suitable for bisecting this.
I know there are several drm repos but I have no clue what is in what.
Linus' tree is fine:
Can't reproduce on my other box so I will need to do some parts swapping I guess.
hmm, so it does not happen on rv515gl
hopefully can bisect with the rv530
It breaks two commits after 2.6.37-rc3.
Luckily it's in the rc range where the kernels build and boot, bisecting something before rc with Linus tree is hell.
The first cut which was halfway between 2.6.36 and 2.6.37 would not boot and had some oops in atl1 which I happen to use to connect to the box.
Author: Alex Deucher <firstname.lastname@example.org>
Date: Fri Nov 19 23:27:04 2010 +0000
drm/radeon/kms: fix resume regression for some r5xx laptops
(In reply to comment #6)
> commit f24d86f1a49505cdea56728b853a5d0a3f8e3d11
> Author: Alex Deucher <email@example.com>
> Date: Fri Nov 19 23:27:04 2010 +0000
> drm/radeon/kms: fix resume regression for some r5xx laptops
Are you saying that with this commit reverted it works?
I did not try to revert it. It's way old. Just tried the kernel before and after.
Note that this is very hardware specific, I get the issue with rv530 but not rv515gl.
(In reply to comment #8)
> I did not try to revert it. It's way old. Just tried the kernel before and
> Note that this is very hardware specific, I get the issue with rv530 but not
So the commit before it worked and the one after it did not?
Yes, it does not work with this commit.
I tried to patch a revert on top of 2.6.37 and the kernel suspends fine then.
Author: Michal Suchanek <firstname.lastname@example.org>
Date: Fri Apr 1 23:24:17 2011 +0200
Revert "drm/radeon/kms: fix resume regression for some r5xx laptops"
This reverts commit f24d86f1a49505cdea56728b853a5d0a3f8e3d11.
Author: Linus Torvalds <email@example.com>
Date: Tue Jan 4 16:50:19 2011 -0800
Created attachment 45164 [details] [review]
This patch should fix it.
With the patch 2.6.37 suspends and resumes, 2.6.38 suspends (which was not possible without it ) and locks up on resume.
On rv515gl 2.6.38 suspends and resumes fine without patches.
(In reply to comment #12)
> With the patch 2.6.37 suspends and resumes, 2.6.38 suspends (which was not
> possible without it ) and locks up on resume.
Can you bisect (and apply the patch from comment 11 as needed) to track down what broken resume?
ok, with the patch 2.6.37 works, 2.6.38 and head suspends but lockups on resume.
I guess time for another bisect.
Is the fix going to be applied?
Any luck bisecting the resume issues?
Those are not caused by Radeon.
They were only hidden by the Radeon issue because it came earlier.
(In reply to comment #17)
> Those are not caused by Radeon.
> They were only hidden by the Radeon issue because it came earlier.
So the patch alone fixes suspend and resume?
The resume issue should be fixed in 2.6.39-rc3.
Author: H. Peter Anvin <firstname.lastname@example.org>
Date: Wed Apr 6 13:10:02 2011 -0700
x86, hibernate: Initialize mmu_cr4_features during boot
Restore the initialization of mmu_cr4_features during boot, which was
removed without comment in checkin e5f15b45ddf3afa2bbbb10c7ea34fb32b6de0a0e
x86: Cleanup highmap after brk is concluded
thereby breaking resume from hibernate. This restores previous
functionality in approximately the same place, and corrects the
I've sent the patch to Dave.
Fixed in 18.104.22.168.