Bug 35175

Summary:	Split up XMPP stanza tests
Product:	Wocky	Reporter:	Stef Walter <stefw>
Component:	General	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	sjoerd, stefw, will
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Stef Walter 2011-03-10 05:21:56 UTC

Split up the wocky XMPP stanza tests so they each test one thing. This is one of the best practices of testing, although obviously shouldn't be a hard and fast rule.

Comment 1 Stef Walter 2011-03-10 05:26:29 UTC

Fixed here: http://git.collabora.co.uk/?p=user/stefw/wocky.git;a=commit;h=02f235609a9cfc4df076c3d4fc1d01e39c91b9e5

Comment 2 Will Thompson 2011-03-10 06:18:00 UTC

 static void
-test_build_iq_result (void)
+test_build_iq_result_simple_ack (void)
 {
   WockyStanza *iq, *reply, *expected;
 
@@ -37,6 +37,20 @@ test_build_iq_result (void)
 
   g_object_unref (reply);
   g_object_unref (expected);
+}


I think this will leak 'iq'.

Otherwise looks good.

Comment 3 Will Thompson 2011-03-10 08:32:03 UTC

Merged; thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.