Bug 35175 - Split up XMPP stanza tests
Summary: Split up XMPP stanza tests
Status: RESOLVED FIXED
Alias: None
Product: Wocky
Classification: Unclassified
Component: General (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 05:21 UTC by Stef Walter
Modified: 2011-03-10 08:32 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Stef Walter 2011-03-10 05:21:56 UTC 
Split up the wocky XMPP stanza tests so they each test one thing. This is one of the best practices of testing, although obviously shouldn't be a hard and fast rule.
Comment 2 Will Thompson 2011-03-10 06:18:00 UTC 
 static void
-test_build_iq_result (void)
+test_build_iq_result_simple_ack (void)
 {
   WockyStanza *iq, *reply, *expected;
 
@@ -37,6 +37,20 @@ test_build_iq_result (void)
 
   g_object_unref (reply);
   g_object_unref (expected);
+}


I think this will leak 'iq'.

Otherwise looks good.
Comment 3 Will Thompson 2011-03-10 08:32:03 UTC 
Merged; thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.